This repository was archived by the owner on Sep 20, 2022. It is now read-only.
Remove "coap-chat" application#80
Merged
chrysn merged 1 commit intoRIOT-OS:masterfrom Sep 19, 2022
chrysn-pull-requests:remove-chat-application
Merged
Remove "coap-chat" application#80chrysn merged 1 commit intoRIOT-OS:masterfrom chrysn-pull-requests:remove-chat-application
chrysn merged 1 commit intoRIOT-OS:masterfrom
chrysn-pull-requests:remove-chat-application
Conversation
benpicco
approved these changes
Sep 19, 2022
Member
Author
|
Thanks. I prefer to merge this only after #78 is through; I'll rebase it there, which will make it easier for anyone who'd like to revive this to just apply the revert of the commit. |
chrysn
added a commit
to chrysn-pull-requests/RIOT
that referenced
this pull request
Sep 20, 2022
…remove-chat-application Remove "coap-chat" application
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example has become outdated and doesn't show current CoAP practice in RIOT any more. Unless anyone steps in to update it, its quality seems to be too low to allow moving it in with RIOT as is being worked on in RIOT-OS/RIOT#18602.
(I'm not updating it, not only for lacking time, but also because I don't think it's a particularly good example; see discussion in 18602 for details).
Suggested in: RIOT-OS/RIOT#18602 (comment)