Open
Conversation
This has been causing warnings all over the place, just because it was a marker variant that was currently not in use. As no markers will be added any more as per the deprecation note, this can go already.
The CC/CFLAGS are thus not exported any more (riot-wrappers doesn't need them since [79]), and the modules list is not neede any more because it was only taken in to be forwarded. [79]: RIOT-OS/rust-riot-wrappers#79
chrysn
added a commit
that referenced
this pull request
Feb 1, 2024
This is not a breaking change, it just turns what used to be a build.rs error into a later error (eg. when used with an older riot-wrappers, that would be missing modules -- but only if the build system suddenly stopped passing in the variable). Tolerating the absence allows the build system to phase out passing dummy values into RIOT_USEMODULES even before [38] is through. [38]: #38
Member
Author
|
When we follow through with this, we'll have to have a solution to RIOT-OS/rust-riot-wrappers#144 -- but a) maybe we do something like #32 first, b) maybe that resolves itself, and c) we can still switch to depending on RIOT configured env stuff. Let's cross that bridge then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With riot-wrappers ceasing to depend on exported variables in RIOT-OS/rust-riot-wrappers#79, the door is open for stopping the re-export of variables and setting
links="riot-sys"(which as a matter of fact we don't do: We don't link it in, we merely provide a static library to be combined with it).This is a breaking change, and would make a 0.8; nonetheless, riot-wrappers could stay compatible with 0.7 and 0.8 simultaneously (we may not want it to because it won't be tested, but it's convenient that riot-wrappers doesn't really need to change -- it can just stop using something riot-sys provides before riot-sys jumps the version and stops providing it).