Conversation
chrysn
force-pushed
the
silent-errors
branch
from
26b6bd9 to
064663c
Compare
Member
Author
|
Rebased onto main now that #57 made things work again. |
mguetschow
approved these changes
Feb 24, 2025
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Looks sensible to me (though without being a Rust expert). Thanks!
Member
Author
|
Thanks for having a look, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugging RIOT-OS/RIOT#21079 was a bit of a mess because C2Rust, at least on unhappy paths, sometimes prints errors that it doesn't really treat as critical. Those get ignored (because cargo doesn't even show those outputs), but then when something goes wrong in C2Rust, they send the user on a fool's errand. Fixing those I found while debugging it to not have to see them again.
Both fixes have extra comments that should keep me from going "do we really need that? *tries rebuilding* still works, we can strip that out!!!elf" later.