CI: Use compile_like_murdock instead of buildtest#59
Conversation
.github/workflows/buildtest.yml
Outdated
| cargo update -p riot-sys -p riot-wrappers --aggressive | ||
| cargo tree | ||
| make buildtest BUILDTEST_MAKE_REDIRECT='' | ||
| ./dist/tools/compile_test/compile_like_murdock.py -b $BOARDS |
There was a problem hiding this comment.
| ./dist/tools/compile_test/compile_like_murdock.py -b $BOARDS | |
| ./dist/tools/compile_test/compile_like_murdock.py -b $BOARDS -j16 |
The Python script does not set the thread count by default. 16 Threads is what the Docker workflow uses too.
There was a problem hiding this comment.
Thanks; updating that. (Gotta update a bit more b/c this used to build example-by-example to enhance visibility of bugs, and now I have to move compile_like_murdock out of the loop -- given how much runway it needs to get started, that's probably a good thing anyway).
There was a problem hiding this comment.
You can still build it in the loop:
for D in ${DIRS}; do
cd ${D}
echo "::group::Building ${D}"
cargo update -p riot-sys -p riot-wrappers --aggressive
cargo tree
+ cd -
+ ./dist/tools/compile_test/compile_like_murdock.py -b $BOARDS -a ${D} -j16
- ./dist/tools/compile_test/compile_like_murdock.py -b $BOARDS -j16
- cd -
echo "::endgroup::"
doneJust go back to the root directory before building and specify the directory in the -a application command.
There was a problem hiding this comment.
Nice trick swapping things around, I'd have started storing PWD in $RIOT and things would be more messy.
But probably the more I let the tool do its job, the more things will just work -- and this way, the threads get used well. I guess that the old buildtest would have shown the errors, so I'd have to go an extra mile to make this one show the right output. Instead, I'll leave that for future me who will automatically have provided a test case for "build fails" and can work from there :-)
c8beb8d to
a7c9877
Compare
See-Also: RIOT-OS/RIOT#21359