Skip to content

Improve finding rocm-smi#108

Open
trixirt wants to merge 1 commit intoROCm:masterfrom
trixirt:fedora-smi
Open

Improve finding rocm-smi#108
trixirt wants to merge 1 commit intoROCm:masterfrom
trixirt:fedora-smi

Conversation

@trixirt
Copy link

@trixirt trixirt commented Aug 30, 2024

On Fedora, rocm-smi is a standard package and is installed to /usr/bin So when run_kfdtest.sh is run this error is produced

find: ‘/opt/rocm*’: No such file or directory

First redirect stderr to dev/null on the original search. Then fall back to either looking for rocm-smi in BIN_DIR or look for it in the PATH.

On Fedora, rocm-smi is a standard package and is installed to /usr/bin
So when run_kfdtest.sh is run this error is produced

find: ‘/opt/rocm*’: No such file or directory

First redirect stderr to dev/null on the original search.
Then fall back to either looking for rocm-smi in BIN_DIR or
look for it in the PATH.

Signed-off-by: Tom Rix <Tom.Rix@amd.com>
@Mystro256
Copy link
Contributor

This has been merged into the upcoming release, thanks!

@Mystro256
Copy link
Contributor

FYI it'll actually land over here because we're moving this into rocr:
https://github.com/ROCm/ROCR-Runtime/commits/amd-staging/

There's a slight delay to mirror from internal to external git.

@kentrussell kentrussell force-pushed the master branch 3 times, most recently from 56a16c2 to 06a9b94 Compare December 6, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants