Properly nest build time headers to match arrangement at install time.#98
Open
stellaraccident wants to merge 5 commits intoROCm:masterfrom
Open
Properly nest build time headers to match arrangement at install time.#98stellaraccident wants to merge 5 commits intoROCm:masterfrom
stellaraccident wants to merge 5 commits intoROCm:masterfrom
Conversation
Add new structures for HW Exception events and copy data from KFD to expose to upper layers. Change-Id: Icd5eb98997c47620e3b86277ab6d3abb7ed7d56f
granularity check is added in kfd w/ below patch:
commit 270c7a8375a91fec2fb4e2c253e3955d9b7540b4
Author: Jesse Zhang <jesse.zhang@amd.com>
Date: Fri Oct 20 09:43:51 2023 +0800
drm/amdkfd: Fix shift out-of-bounds issue
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index a690dced6860..f2b33fb2afcf 100644
Change-Id: I8cb037e3bf5db0a85661494b77e59984eca4d98d
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -781,7 +781,7 @@ svm_range_apply_attrs(struct kfd_process *p, struct svm_range *prange,
prange->flags &= ~attrs[i].value;
break;
case KFD_IOCTL_SVM_ATTR_GRANULARITY:
- prange->granularity = attrs[i].value;
+ prange->granularity = min_t(uint32_t, attrs[i].value, 0x3F);
break;
default:
WARN_ONCE(1, "svm_range_check_attrs wasn't called?");
Test cases have to been modified accordingly otherwise KFDSVMRangeTest.SetGetAttributesTest
fails.
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Change-Id: Ifff47556bc398da6b18ad26ac545d139b63b0c92
(cherry picked from commit d36c28c)
Due to a kernel bug where large unified memory ends up with an incorrect fragment size during migration, the debugger ends up triggering save area corruption. Since the debugger does not work in virtualization and the performance requirement to allocate the save area as unified memory is only for GFX1101 virtualized devices, allocate the save area in system memory for all other GFX11 devices. Note that devices prior to GFX11 have not exhibited issues so keep the save area in unified memory for these devices. Signed-off-by: Jonathan Kim <jonathan.kim@amd.com> Change-Id: I9c09a9af232a26aaece1c1663fdfad756fbbcdf8
This test is still causing issue on GFX11. Change-Id: I4c12e2a410598a7f820bee96eccac6fae9642208 Signed-off-by: David Belanger <david.belanger@amd.com>
The build tree was missing a level of nesting, causing diversions based on in-tree/out-of-tree use.
Contributor
|
I've brought this in internally, but am talking to our packaging team to ensure that it doesn't break any current flows. Also I had to modify kfdtest as well, since that broke without the changed paths |
Contributor
|
So this one missed 6.1, but it should be in the 6.2 release. |
kentrussell
force-pushed
the
master
branch
2 times, most recently
from
56a16c2 to
06a9b94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build tree was missing a level of nesting, causing diversions based on in-tree/out-of-tree use.