Added extra command line option to turn off rccl for causal tests#433
Draft
pranswarup wants to merge 1 commit intoamd-stagingfrom
Draft
Added extra command line option to turn off rccl for causal tests#433pranswarup wants to merge 1 commit intoamd-stagingfrom
pranswarup wants to merge 1 commit intoamd-stagingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USE_RCCL is ON by default from the CMakeLists.txt whenever USE_HIP is ON so omnitrace-causal always has this setting turn on from the compile stage. I added an extra option so the environment variable will not be selectively added to the run environment when an extra command line argument --nrccl is passed. This extra command line argument is used by the add_causal_test to run omnitrace-causal without USE_RCCLP set to true.