Skip to content

Revert "Better handle building rocSPARSE with ROC-TX" #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsandham merged 1 commit into from
Jun 18, 2025
Merged

Revert "Better handle building rocSPARSE with ROC-TX" #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions clients/benchmarks/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,8 @@ if (NOT WIN32)
endif()

if (NOT WIN32)
if(BUILD_WITH_ROCTX)
find_package(roctx REQUIRED)
target_link_libraries(rocsparse-bench PRIVATE roctx::roctx)
if (BUILD_WITH_ROCTX)
target_link_libraries(rocsparse-bench PRIVATE -lroctx64)
target_compile_definitions( rocsparse-bench PRIVATE ROCSPARSE_CLIENTS_WITH_ROCTX )
endif()
endif()
Expand Down
5 changes: 2 additions & 3 deletions clients/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,9 +415,8 @@ if (NOT WIN32)
endif()

if (NOT WIN32)
if(BUILD_WITH_ROCTX)
find_package(roctx REQUIRED)
target_link_libraries(rocsparse-test PRIVATE roctx::roctx)
if (BUILD_WITH_ROCTX)
target_link_libraries(rocsparse-test PRIVATE -lroctx64)
target_compile_definitions( rocsparse-test PRIVATE ROCSPARSE_CLIENTS_WITH_ROCTX )
endif()
endif()
Expand Down
72 changes: 0 additions & 72 deletions cmake/Findroctx.cmake
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions library/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,7 @@ endif()

if (NOT WIN32)
if (BUILD_SHARED_LIBS AND BUILD_WITH_ROCTX)
find_package(roctx REQUIRED)
target_link_libraries(rocsparse PRIVATE roctx::roctx)
target_link_libraries(rocsparse PRIVATE -lroctx64)
target_compile_definitions( rocsparse PRIVATE ROCSPARSE_BUILT_WITH_ROCTX )
endif()
endif()
Expand Down