Revert "Better handle building rocSPARSE with ROC-TX (#484)" (#511)#512
Revert "Better handle building rocSPARSE with ROC-TX (#484)" (#511)#512jsandham wants to merge 1 commit intoROCm:release-staging/rocm-rel-7.0from
Conversation
|
Not clear what you are doing here. Assuming you were originally trying to resolve broken builds for community, much like reported in rocBLAS ROCm/rocBLAS#1579 , so at this point you are causing a revert back to broken builds, so do you have a replacement ready to PR (could add in same PR) ? @rkamd can be consulted as involved in rocblas side. |
We were told by stella this needs to be reverted as the current approach is not acceptable. See here comment on here #484. In short we cannot add another Findxxx.cmake module. I was going to try and spend part of today seeing if I could come up with something else. She pointed to looking at what MIopen does which I think is similar to what you guys are doing with using find_path to look for the header files and the roctx shared library. So I was going to maybe go back to what you guys are doing in rocblas. |
This reverts commit eb9b5cd. See original PR #484 for why we must revert. In short we cannot add another Findxxx.cmake module.