Change how we handle looking for rocTX#515
Merged
jsandham merged 2 commits intoROCm:release-staging/rocm-rel-7.0from Jun 20, 2025
Merged
Change how we handle looking for rocTX#515jsandham merged 2 commits intoROCm:release-staging/rocm-rel-7.0from
jsandham merged 2 commits intoROCm:release-staging/rocm-rel-7.0from
Conversation
…ake module (ROCm#513) * Alternate way to handle building rocsparse with roctx since we cannot use Findroctx.cmake modules
jsandham
requested review from
YvanMokwinski,
kliegeois and
ntrost57
as code owners
YvanMokwinski
approved these changes
Jun 20, 2025
kliegeois
approved these changes
Jun 20, 2025
jsandham
merged commit 2c12519
into
ROCm:release-staging/rocm-rel-7.0
11 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherrypicks commit eb9b5cd followed by commit 502a46e. The first commit reverts how we were looking for rocTX with a Findroctx.cmake module file, while the second commit adds finding rocTX similar to how rocBLAS does. See original PR #484 for why we had to change how we look for rocTX.