Add options to control install behaviour in ASAN builds#138
Add options to control install behaviour in ASAN builds#138lawruble13 wants to merge 3 commits intoROCm:release-staging/rocm-rel-5.7from
Conversation
|
So |
Ah, I misunderstood what you had said in our last discussion. Should there then be a flag to force a target to be ignored in the ASAN build, in addition to this |
| endif() | ||
|
|
||
| if (PARSE_PRIVATE) | ||
| set(BIN_INSTALL_DIR ${BIN_INSTALL_DIR}/${PROJECT_NAME}) |
There was a problem hiding this comment.
This should be ${LIB_INSTALL_DIR}/${PROJECT_NAME}.
|
|
||
| if (PARSE_PRIVATE) | ||
| set(BIN_INSTALL_DIR ${BIN_INSTALL_DIR}/${PROJECT_NAME}) | ||
| set(LIB_INSTALL_DIR ${LIB_INSTALL_DIR}/${PROJECT_NAME}) |
There was a problem hiding this comment.
I think this would be ${LIB_INSTALL_DIR}/${PROJECT_NAME}/lib. Also, we should probably do this for include as well.
No, we should just ignore everything thats not a shared object by default in ASAN builds. Then the |
No description provided.