Add test capability to check if a target includes hip_runtime.h#250
Open
lawruble13 wants to merge 2 commits intoROCm:developfrom
Open
Add test capability to check if a target includes hip_runtime.h#250lawruble13 wants to merge 2 commits intoROCm:developfrom
lawruble13 wants to merge 2 commits intoROCm:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets using HIP should generally not include
hip_runtime.h, and should instead usehip_runtime_amd.h. This adds a function which will test if any of the sources includehip_runtime.h, either directly or indirectly.