Skip to content

Allow suppression of warnings in ROCMChecks#281

Merged
lawruble13 merged 2 commits intodevelopfrom
rocm-check-honours-suppression
Jan 15, 2026
Merged

Allow suppression of warnings in ROCMChecks#281
lawruble13 merged 2 commits intodevelopfrom
rocm-check-honours-suppression

Conversation

@bstefanuk
Copy link
Contributor

@bstefanuk bstefanuk commented Jan 15, 2026

Motivation

Warnings caused by third-party dependencies that are out of the control of a project cannot be suppressed and clutter the build output.

Technical Details

Only adds the warning statement if either ROCM_WARN_TOOLCHAIN_VAR or ROCM_ERROR_TOOLCHAIN_VAR are set, which enables nesting dependency fetches inside of scoped block calls to suppress warnings found by ROCMChecks.

Test Plan

Standard CI testing. Manual function testing for hipblaslt confirms this pattern's validity.

Test Result

Warnings are properly suppressed when ROCM_WARN_TOOLCHAIN_VAR is set to OFF.

Submission Checklist

@bstefanuk bstefanuk changed the title Allow suppression of warning for third-party deps Allow suppression of warnings in ROCMChecks Jan 15, 2026
Copy link
Collaborator

@lawruble13 lawruble13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, for future work we have had some discussions about preferring to define methods which do explicitly scoped suppression of these warnings (for initial work on something like this refer to #156).

@lawruble13 lawruble13 merged commit c01b4f1 into develop Jan 15, 2026
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants