Allow suppression of warnings in ROCMChecks#281
Merged
lawruble13 merged 2 commits intodevelopfrom Jan 15, 2026
Merged
Conversation
lawruble13
approved these changes
Jan 15, 2026
Collaborator
lawruble13
left a comment
There was a problem hiding this comment.
This looks good to me, for future work we have had some discussions about preferring to define methods which do explicitly scoped suppression of these warnings (for initial work on something like this refer to #156).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Warnings caused by third-party dependencies that are out of the control of a project cannot be suppressed and clutter the build output.
Technical Details
Only adds the warning statement if either ROCM_WARN_TOOLCHAIN_VAR or ROCM_ERROR_TOOLCHAIN_VAR are set, which enables nesting dependency fetches inside of scoped
blockcalls to suppress warnings found by ROCMChecks.Test Plan
Standard CI testing. Manual function testing for hipblaslt confirms this pattern's validity.
Test Result
Warnings are properly suppressed when ROCM_WARN_TOOLCHAIN_VAR is set to OFF.
Submission Checklist