Skip to content

Comments

To build and install jax, jaxlib, pjrt and plugin at once.#243

Closed
i-chaochen wants to merge 2 commits intorocm-jaxlib-v0.8.0from
all_wheels_build
Closed

To build and install jax, jaxlib, pjrt and plugin at once.#243
i-chaochen wants to merge 2 commits intorocm-jaxlib-v0.8.0from
all_wheels_build

Conversation

@i-chaochen
Copy link

@i-chaochen i-chaochen commented Jan 8, 2026

Motivation

Now we can just use one line to build everything (jax, jaxlib, pjrt and plugin) as we're used to.

python3 stack.py build --xla-dir=/my/own/xla/path --jax-dir=/my/own/jax/path

Copy link
Collaborator

@charleshofer charleshofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@i-chaochen i-chaochen changed the title To build jaxlib, pjrt and plugin at once To build and install jax, jaxlib, pjrt and plugin at once. Jan 9, 2026
@i-chaochen i-chaochen requested a review from mminutoli January 9, 2026 00:24
@i-chaochen i-chaochen requested a review from Arech8 January 9, 2026 00:29
@charleshofer charleshofer changed the base branch from rocm-jaxlib-v0.8.0 to master January 9, 2026 16:11
@charleshofer charleshofer changed the base branch from master to rocm-jaxlib-v0.8.0 January 9, 2026 16:11
Copy link
Collaborator

@charleshofer charleshofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase and retarget this for master?

@i-chaochen
Copy link
Author

i-chaochen commented Jan 9, 2026

@charleshofer this is master one #244 , I created two PRs

Copy link
Contributor

@Arech8 Arech8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge until comments to #244 are addressed.

Also I'm not sure we should update released branch... Though this only affects the build system, so we could do it, just let's finish with the corresponding PR into the master first.

@Arech8
Copy link
Contributor

Arech8 commented Jan 12, 2026

Also why do you make two separate PRs (into the master and here), instead of having just one main PR merged into the master and then cherry-picking it here? I think, this PR should be discarded in favor of cherry-picking, this helps with maintenance.

@i-chaochen
Copy link
Author

Please don't merge until comments to #244 are addressed.

Also I'm not sure we should update released branch... Though this only affects the build system, so we could do it, just let's finish with the corresponding PR into the master first.

Also why do you make two separate PRs (into the master and here), instead of having just one main PR merged into the master and then cherry-picking it here? I think, this PR should be discarded in favor of cherry-picking, this helps with maintenance.

Yes, I can close this one till #244 is addressed and cherry-pick back.

@i-chaochen i-chaochen closed this Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants