Skip to content

Comments

make env var paths independent of ROCm version#285

Open
JehandadKhan wants to merge 1 commit intomasterfrom
jd/docker_env_paths
Open

make env var paths independent of ROCm version#285
JehandadKhan wants to merge 1 commit intomasterfrom
jd/docker_env_paths

Conversation

@JehandadKhan
Copy link
Collaborator

Motivation

A mismatch in LLVM_PATH or ROCM_PATH based on the minor version breaks logic in XLA where we look for tools such as ld.lld

Technical Details

This PR fixes such issues by using the symlink path instead which is stable across versions.

Test Plan

Once the docker is built a simple code snippet such as

import jax.numpy as jnp
print(jnp.ones(5))

Should work successfully, if the path is not set correctly, this will fail.

Test Result

Submission Checklist

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant