make env var paths independent of ROCm version#285
Open
JehandadKhan wants to merge 1 commit intomasterfrom
Open
make env var paths independent of ROCm version#285JehandadKhan wants to merge 1 commit intomasterfrom
JehandadKhan wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A mismatch in LLVM_PATH or ROCM_PATH based on the minor version breaks logic in XLA where we look for tools such as
ld.lldTechnical Details
This PR fixes such issues by using the symlink path instead which is stable across versions.
Test Plan
Once the docker is built a simple code snippet such as
Should work successfully, if the path is not set correctly, this will fail.
Test Result
Submission Checklist