[WIP] Make the nightly job use TheRock instead of ROCm#305
Draft
charleshofer wants to merge 1 commit intomasterfrom
Draft
[WIP] Make the nightly job use TheRock instead of ROCm#305charleshofer wants to merge 1 commit intomasterfrom
charleshofer wants to merge 1 commit intomasterfrom
Conversation
813b0cd to
9874008
Compare
alekstheod
reviewed
Feb 12, 2026
| fail-fast: false | ||
| matrix: | ||
| rocm-version: ["7.1.1", "7.2.0"] | ||
| rocm-version: ["7.1.1", "7.2.0", "7.12.0"] |
Contributor
There was a problem hiding this comment.
Not sure if you are interested but we could do a hermetic build with therock. Check openxla rocm_ci_hermetic config for more details.
9874008 to
a83095f
Compare
Contributor
|
Can we also create manylinux images so we can reuse them on PR checks? |
Collaborator
Author
Yes. I need to rebase this now that I merged the manylinux PR. I'll add those when I rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TheRock is the future of ROCm. We're going to start getting our ROCm installations from TheRock instead of the old ROCm release pipeline. Eventually, we want to be in a place where we can install ROCm through the Python wheels in TheRock, but for now, our build scripts and plugin wheels only work with TheRock's tarballs unzipped into
/opt/rocm. This changes the nightly workflow to pull a nightly tarball from TheRock instead of using the old ROCm release and adds TheRock builds to the base docker image build workflow.Technical Details
Adds build options for
therock-pathin our GHA workflows. Much like how we used to pin the nightly build to specific build numbers of ROCm, we "pin" to a specific nightly build of TheRock by passing in a URL.Test Plan
TODO