Open
Conversation
Arech8
approved these changes
Feb 12, 2026
| -@jax//tests:gpu_memory_flags_test_gpu | ||
| -@jax//tests:lax_numpy_test_gpu | ||
| -@jax//tests:lax_test_gpu | ||
| -@jax//tests:linalg_test_gpu |
Collaborator
There was a problem hiding this comment.
I assume that this test case was failing in CI and that's why you're removing it? If that's the case, no complaints from me.
Contributor
Author
There was a problem hiding this comment.
Yes the test was failing. I think in your pipeline you have several --test_filter cases. In bazel the last one overrides. So in fact not all the tests were executed but only the one in the last filter. Usually we do --test_filter="Test1|Test2|Test3" Not sure however if that is a correct syntax for asltest but bazelwise --test_filter several times is not correct.
charleshofer
approved these changes
Feb 12, 2026
Contributor
Author
|
I wouldn't merge it right now. Seems xla does break several tests! We need to work on xla to fix them! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Bump xla rocm-jaxlib-v0.8.2 head