Fix rocminfo when run within docker environments.#49
Open
iotamudelta wants to merge 1 commit intoROCm:masterfrom
Open
Fix rocminfo when run within docker environments.#49iotamudelta wants to merge 1 commit intoROCm:masterfrom
iotamudelta wants to merge 1 commit intoROCm:masterfrom
Conversation
Currently, rocminfo will fail when executed inside a docker container due to being unable to lsmod inside docker. This has impacts on rocprofiler use. Fix this behavior by querying initstate of the amdgpu module from /sys/module/amdgpu instead. If initstate is marked "live" everything if fine - error out with either "not loaded" (initstate file does not exist) or "not live" (initstate file does not contain "live" string).
|
Can someone review this please? LGTM, and the current check is pretty dumb.
|
Contributor
dayatsin-amd
left a comment
dayatsin-amd
left a comment
There was a problem hiding this comment.
Looks good to me. I will submit the patch from our internal repo
|
Querying |
|
Unable to import to rocm-systems due to merge conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, rocminfo will fail when executed inside a docker container
due to being unable to lsmod inside docker. This has impacts on rocprofiler use.
Fix this behavior by querying initstate of the amdgpu module from
/sys/module/amdgpu instead. If initstate is marked "live" everything is
fine - error out with either "not loaded" (initstate file does not
exist) or "not live" (initstate file does not contain "live" string).