Interface proposal : pull request 1#53
Open
yoann-heitz wants to merge 1 commit intoROCm:rocm-4.3.xfrom
Open
Conversation
Deleted a line that makes rocprof abort when using fine grained control one several APIs at a time. The parsing function in libtracer_tool.so that parses the input XML file that specifies the functions for which the user wants to activate the tracing callbacks seems to handle correctly cases where fine-grained control is used on several APIs. This line can be safely deleted.
yoann-heitz
changed the title
yoann-heitz
force-pushed
the
rocm-4.3.x
branch
from
5ccee80 to
125e1b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first pull request for the proposal for a plugin interface for the rocprof command. It allows fine-grained control to work on several APIs at a time.
Warning :
When using fine-grained control, only some functions (those specified by the user) will be traced. It may lead to crashes at the post-processing step (conversion from text to JSON/SQLITE) since the conversion scripts require data from the payloads of events triggered by specific functions and users may disable the callbacks for these functions. However, the text files obtained with the -d option will not be corrupted and contain only the events specified by the user.