SWDEV-294351 Fixed zero bandwith for hsa-api and hip-api traces#59
Open
kikimych wants to merge 1 commit intoROCm:rocm-4.3.xfrom
Open
SWDEV-294351 Fixed zero bandwith for hsa-api and hip-api traces#59kikimych wants to merge 1 commit intoROCm:rocm-4.3.xfrom
kikimych wants to merge 1 commit intoROCm:rocm-4.3.xfrom
Conversation
Hsa ops traces correlation id is number of hsa async-copy called. Hsa api does not log any correlation id, but can be calculated implicitly as number of current hsa_amd_memory_async_copy called. Hip ops correlation id index in rec_vals was 7 instead of 8. Hip api and hip ops correlation id were consistent. String manipulation in copy_line calculation in register_copy and register_activity is increasing copy_line length. Replaced string manipulation with class instance and fields modification. Alexey.Akimov@amd.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hsa ops traces correlation id is number of hsa async-copy called.
Hsa api does not log any correlation id, but can be calculated
implicitly as number of current hsa_amd_memory_async_copy called.
Hip ops correlation id index in rec_vals was 7 instead of 8.
Hip api and hip ops correlation id were consistent.
String manipulation in copy_line calculation in register_copy
and register_activity is increasing copy_line length. Replaced
string manipulation with class instance and fields modification.
Alexey.Akimov@amd.com