Open
Conversation
Fixed --trace-start on/of not working issue. roctracer_stop() call in tool_load() function does nothing before hsa activities registered. That forces tracing to be enabled from start independently from option value. tool_load is called in library constructor, activities are registered in library OnLoad() callback, whih is called later by hsa_runtime. Duplicated roctracer_stop() call in OnLoad() callback to fix this. alexey.akimov@amd.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed --trace-start on/of not working issue.
roctracer_stop() call in tool_load() function does nothing before
hsa activities registered. That forces tracing to be enabled from
start independently from option value. tool_load is called in
library constructor, activities are registered in library OnLoad()
callback, whih is called later by hsa_runtime.
Duplicated roctracer_stop() call in OnLoad() callback to fix this.
alexey.akimov@amd.com