suppress cuda error messages (harmless) when doing training on ROCm#580
Open
cj401-amd wants to merge 3 commits intorocm-jaxlib-v0.8.0from
Open
suppress cuda error messages (harmless) when doing training on ROCm#580cj401-amd wants to merge 3 commits intorocm-jaxlib-v0.8.0from
cj401-amd wants to merge 3 commits intorocm-jaxlib-v0.8.0from
Conversation
cj401-amd
requested review from
ScXfjiang,
draganmladjenovic,
i-chaochen and
pemeliya
i-chaochen
reviewed
Jan 26, 2026
Collaborator
i-chaochen
left a comment
i-chaochen
left a comment
There was a problem hiding this comment.
Please upstream this to openxla
i-chaochen
added
cherry-pick-candidate
i-chaochen
reviewed
Jan 27, 2026
xla/service/computation_placer.cc
Outdated
| if (placers.find(id) != placers.end()) { | ||
| LOG(WARNING) << "Computation placer creation function is already " | ||
| "registered for this platform"; | ||
| return; |
Collaborator
There was a problem hiding this comment.
once you return here, this wouldn't execute
xla/xla/service/computation_placer.cc
Line 188 in 3e14c4b
cj401-amd
force-pushed
the
ci_cj_suppress_cuda_rocm-jaxlib-v0.8.0
branch
from
3e14c4b to
3e8bac9
Compare
i-chaochen
approved these changes
Jan 27, 2026
Collaborator
i-chaochen
left a comment
i-chaochen
left a comment
There was a problem hiding this comment.
LGTM, please put your upstream PR in the PR description
| void initialize_cublas() { | ||
| // Check if already registered before attempting - prevents duplicate | ||
| // registration error messages (can happen with multiple library loads) | ||
| auto already_registered = PluginRegistry::Instance()->HasFactory( |
Collaborator
There was a problem hiding this comment.
don't we need this in rocm_blas.cc side?
Author
There was a problem hiding this comment.
it's been implemented already here https://github.com/ROCm/xla/blame/rocm-jaxlib-v0.8.0/xla/stream_executor/rocm/rocm_blas.cc#L1283. so on NV side, it won't emit error message related to ROCm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.