Sync mgpu tests with xla_mgpu config#597
Open
alekstheod wants to merge 1 commit intorocm-jaxlib-v0.7.1from
Open
Sync mgpu tests with xla_mgpu config#597alekstheod wants to merge 1 commit intorocm-jaxlib-v0.7.1from
alekstheod wants to merge 1 commit intorocm-jaxlib-v0.7.1from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR synchronizes multi-GPU test configurations by migrating changes from an upstream XLA pull request. The changes introduce new CI configuration options to better handle multi-GPU and single-GPU test scenarios.
Changes:
- Added logic to handle
--config=ci_multi_gpuand--config=ci_single_gpuflags in the test runner - Created a new
ci_multi_gpuconfiguration that maps to the existingxla_mgpuconfig
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build_tools/rocm/run_xla_ci_build.sh | Adds conditional logic to set appropriate tag filters based on CI configuration type (multi-GPU vs single-GPU) |
| build_tools/rocm/rocm_xla.bazelrc | Maps the new ci_multi_gpu configuration to the existing xla_mgpu test configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate changes from: #592