forked from OrMSC/SimOR
-
Notifications
You must be signed in to change notification settings - Fork 0
PnR Capacity and New Landuse files from Metro #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit avoids a zero probability error since the max bike distance used in trip destination seems to be farther than the maz OD DISTWALK cutoff. Long term fix is actual bike logsum from bike model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily standardizes the use of employment and external zone variables throughout the configuration files, updates the destination choice size terms to match new data conventions, and modernizes the CI workflow to use UV instead of Conda. Additionally, it introduces new variables and fixes for land use annotation and park-and-ride modeling.
Standardization and Data Consistency:
EMP_TOTwithEMP_TOTALin configuration and annotation files to ensure consistent use of employment totals. (resident/configs/accessibility.csv,resident/configs/annotate_landuse.csv,resident/configs/accessibility.yaml) [1] [2] [3] [4] [5]EMP_NHTMFG,EMP_HTMFG, etc., withEMP_MFG, and consolidating external indicators into theEXTERNALcolumn. (resident/configs/destination_choice_size_terms.csv)External Zone and Worker Identification:
EXTERNALindicator rather than specific external counts, and updated related expressions accordingly. (resident/configs/external_worker_identification.csv,resident/configs/external_non_mandatory_identification.csv) [1] [2]Park-and-Ride and Parking Modeling:
PNR_SPACESinstead ofPNR_CAP_TOTAL, added new utility variables for lot penalties and vehicle/stop type constants, and improved the configuration for park-and-ride eligibility. (resident/configs/park_and_ride_lot_choice.csv,resident/configs/park_and_ride_lot_choice.yaml) [1] [2]resident/configs/parking_location_choice_annotate_trips_preprocessor.csv) [1] [2]Development and CI Workflow:
.github/workflows/ci.yml) [1] [2].vscode/launch.json)Land Use Annotation Enhancements:
ACTIVE_ACRES,totint, and others, and updated the logic for identifying parking zones and employment density. (resident/configs/annotate_landuse.csv)