Skip to content

Conversation

@dhensle
Copy link
Collaborator

@dhensle dhensle commented Jan 15, 2026

This pull request primarily standardizes the use of employment and external zone variables throughout the configuration files, updates the destination choice size terms to match new data conventions, and modernizes the CI workflow to use UV instead of Conda. Additionally, it introduces new variables and fixes for land use annotation and park-and-ride modeling.

Standardization and Data Consistency:

  • Replaced all instances of EMP_TOT with EMP_TOTAL in configuration and annotation files to ensure consistent use of employment totals. (resident/configs/accessibility.csv, resident/configs/annotate_landuse.csv, resident/configs/accessibility.yaml) [1] [2] [3] [4] [5]
  • Updated destination choice size term columns and segments to match new conventions, replacing, e.g., EMP_NHTMFG, EMP_HTMFG, etc., with EMP_MFG, and consolidating external indicators into the EXTERNAL column. (resident/configs/destination_choice_size_terms.csv)

External Zone and Worker Identification:

  • Modified external worker and non-mandatory identification logic to use the unified EXTERNAL indicator rather than specific external counts, and updated related expressions accordingly. (resident/configs/external_worker_identification.csv, resident/configs/external_non_mandatory_identification.csv) [1] [2]

Park-and-Ride and Parking Modeling:

  • Changed the park-and-ride lot size and eligibility logic to use PNR_SPACES instead of PNR_CAP_TOTAL, added new utility variables for lot penalties and vehicle/stop type constants, and improved the configuration for park-and-ride eligibility. (resident/configs/park_and_ride_lot_choice.csv, resident/configs/park_and_ride_lot_choice.yaml) [1] [2]
  • Adjusted parking eligibility logic for trips to base it on whether cost is positive, rather than a land use parking type, and added a FIXME for further improvement. (resident/configs/parking_location_choice_annotate_trips_preprocessor.csv) [1] [2]

Development and CI Workflow:

  • Updated the GitHub Actions CI workflow to use UV for dependency management and Python setup instead of Conda, and renamed the test job for clarity. (.github/workflows/ci.yml) [1] [2]
  • Added a new VSCode launch configuration for running the preprocessor script and updated the output directory for cropped runs. (.vscode/launch.json)

Land Use Annotation Enhancements:

  • Added several missing or placeholder variables to land use annotation, such as ACTIVE_ACRES, totint, and others, and updated the logic for identifying parking zones and employment density. (resident/configs/annotate_landuse.csv)

dhensle and others added 24 commits September 29, 2025 15:15
This commit avoids a zero probability error since the max bike distance used in trip destination seems to be farther than the maz OD DISTWALK cutoff. Long term fix is actual bike logsum from bike model.
@dhensle dhensle merged commit 86641dc into initial_model_setup Jan 16, 2026
2 checks passed
@dhensle dhensle deleted the pnr_capacity branch January 16, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants