-
-
Notifications
You must be signed in to change notification settings - Fork 88
Migrate Unity Realtime SDK to GA API #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/9.0.0
Are you sure you want to change the base?
Conversation
Summary - Update Realtime session/response models and event/content names to GA schema - Add GA audio config types and session type enums; default audio-only output modalities - Update WebSocket flow to connect directly, send session.update after session.created, and support client secrets - Refresh samples/docs and adjust Realtime tests for GA behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you accidentally put this in the wrong directory. It should go under Samples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets revert this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets revert back to min supported version. Can be updated to latest 2021.3
| /// The <see cref="JsonSerializationOptions"/> to use when making calls to the API. | ||
| /// </summary> | ||
| internal static JsonSerializerSettings JsonSerializationOptions { get; } = new() | ||
| public static JsonSerializerSettings JsonSerializationOptions { get; } = new() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets keep this internal
StephenHodgson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! just a few change requests
Summary