You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixed some errors, warnings and notes I (and hopefully everyone) was getting from R check.
This is progress towards passing the CRAN check!
explicit :: calls to packages for external functions
fixed dependencies declared in DESCRIPTION, I just followed check's requirements there
removing all non-ASCII UTF characters, that is mostly greek characters and replace them with corresponding LaTeX specials in equations
removed g++-specific flags and commands in the Makevars (wildcard() and -o2)
The package builds without errors (still 3 warnings standing), but I have not attempted to run it - unsure what is the usual procedure to test the package.
Hi Theo,
just one question: are you running R CMD check to add the GitHub Action for checking the R package?
The warnings only occur when running R CMD check, but not when users install the package from GitHub or if people would install it in RStudio. That's why we haven't had the fix as a priority. But I guess that GitHub is running R CMD check?
Regarding CRAN: we actually haven't decided yet whether RangeShiftR should be on CRAN.
I will try to look at the PR by the end of the week.
are you running R CMD check to add the GitHub Action for checking the R package?
Not yet, but I do indeed have this in mind! This was just because I started working on #31 and noticed the check couldn't pass on my machine because of these doc issues, so I wanted to fix part of it (and de-clutter the log) before changing anything else.
I guess that GitHub is running R CMD check?
Well since you (maintainer/dev) write the yaml script that controls what is run on GitHub Actions, what is done on GitHub is up to you :)
But I believe it is indeed standard practice to run R CMD CHECK (e.g. via the r-lib script) to ensure that your package complies with CRAN requirements through time.
we actually haven't decided yet whether RangeShiftR should be on CRAN.
Fair enough! Well if we do, this is some progress towards it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed some errors, warnings and notes I (and hopefully everyone) was getting from R check.
This is progress towards passing the CRAN check!
::calls to packages for external functionswildcard()and-o2)The package builds without errors (still 3 warnings standing), but I have not attempted to run it - unsure what is the usual procedure to test the package.