Add the effect variable to the emit that is being removed to player#117
Open
nelsonsbrian wants to merge 1 commit intoRanvierMUD:masterfrom
Open
Add the effect variable to the emit that is being removed to player#117nelsonsbrian wants to merge 1 commit intoRanvierMUD:masterfrom
nelsonsbrian wants to merge 1 commit intoRanvierMUD:masterfrom
Conversation
Don't really see a reason not to, but my use case is to listen for the 'effectRemoved' on the player and update my websocket client with that specific effect being removed. This would be the cleanest way to do it.
MarchosiasM
reviewed
May 8, 2020
MarchosiasM
left a comment
MarchosiasM
left a comment
There was a problem hiding this comment.
Makes sense. The subscribed service could do a lot being aware of what the actual effect being removed is.
|
Great idea! |
azigler
added a commit
to azigler/core
that referenced
this pull request
Jun 7, 2020
- improve docstrings - use RanvierMUD#74, RanvierMUD#93, RanvierMUD#98, RanvierMUD#100, RanvierMUD#103, RanvierMUD#106, RanvierMUD#109, RanvierMUD#117, RanvierMUD#104, RanvierMUD#119, RanvierMUD#105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't really see a reason not to, but my use case is to listen for the 'effectRemoved' on the player and update my websocket client with that specific effect being removed. This would be the cleanest way to do it.