Open
Conversation
Member
|
Code looks solid, I'd really like a unit test for it though |
Contributor
Author
|
I have absolutely no idea how to do that, but I'm willing to try =) Any examples I can look at? |
Member
|
https://github.com/RanvierMUD/core/blob/master/test/unit/Attribute.js is a super simple example. I'm been really bad about adding tests so there aren't many but that's a good base to work off of, it's using mocha |
azigler
added a commit
to azigler/core
that referenced
this pull request
Jun 7, 2020
- improve docstrings - use RanvierMUD#74, RanvierMUD#93, RanvierMUD#98, RanvierMUD#100, RanvierMUD#103, RanvierMUD#106, RanvierMUD#109, RanvierMUD#117, RanvierMUD#104, RanvierMUD#119, RanvierMUD#105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you Area#addRoom() it adds the room to the floor map, but you if call Area#removeRoom, it removes it from the area, but leaves it in the floor map. Resulting in bad things, like crashes when a player tries to view adjacent rooms that lookup their implied exits through the floor map. Any suggestions on how this could better?