revert: reimplement read alongs's getImages() API #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
Contributor
|
joanise
approved these changes
Jan 12, 2026
Member
joanise
left a comment
joanise
left a comment
There was a problem hiding this comment.
Sorry, I missed this one. All good, thanks for fixing this!
sergeleger
deleted the
dev.swl/502-a-removed-image-from-a-read-along-is-still-included-in-offline-html-exports
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
Reverts an inadvertent API change to the web component's
getImages()functionality. The correct API should return an object withnullvalues for images that had been deleted from the read along:Studio Web uses this
nullinformation as an indicator to remove a previously attached image from the download package.Fixes?
Closes #502
Feedback sought?
Still works as expected.
Priority?
Low.
Tests added?
No.
How to test?
Confidence?
High.
Version change?
No.