This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Updating master to support react > 16 + native > 0.52#158
Open
gabrielrotbart wants to merge 8 commits intoRealOrangeOne:masterfrom
Open
Updating master to support react > 16 + native > 0.52#158gabrielrotbart wants to merge 8 commits intoRealOrangeOne:masterfrom
gabrielrotbart wants to merge 8 commits intoRealOrangeOne:masterfrom
Conversation
added 2 commits
February 20, 2018 13:19
Author
|
Using react-addons-perf latest version but its not compatible with React 16. Not sure how to fix this or why it's working fine for me. Will need to find time to dig into it further |
Owner
|
I believe most of these changes are fixed in #120 ? |
Author
|
I saw a mention of the re-write in one of the issues. The changes I pushed got my test suite running again with React > 16 so was just trying to help folks that are stuck until the re-write lands. |
|
any chance we can get this merged? |
|
I also waiting for this patch. React 16.2 + latest RN not working with react-native-mock |
|
A workaround is mentioned here: https://stackoverflow.com/questions/42039383/how-to-use-enzyme-for-react-native-with-jest |
|
Still waiting for this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went through and fixed all the deprecated API's.
Fixes #139
It's probably not the cleanest update and I didn't add any tests but they all pass.
Enzyme works with react-native >= 0.52 which is what I needed.
Let me know if there are any issues I'm missing.