This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Added peerDependencies to devDependencies to fix CircleCi test#161
Open
nijolas wants to merge 1 commit intoRealOrangeOne:rewritefrom
nijolas:rewrite
Open
Added peerDependencies to devDependencies to fix CircleCi test#161nijolas wants to merge 1 commit intoRealOrangeOne:rewritefrom nijolas:rewrite
nijolas wants to merge 1 commit intoRealOrangeOne:rewritefrom
nijolas:rewrite
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for the broken CircleCI test - adding the peerDependencies to devDependencies will mean npm install has a react native install so that the haste build command doesn't fail.
Will also make developing easier as your dependent frameworks will get installed with an npm/yarn