Add support for exporting colors from variables definitions in a JSON#228
Open
aduuub wants to merge 3 commits intoRedMadRobot:masterfrom
Open
Add support for exporting colors from variables definitions in a JSON#228aduuub wants to merge 3 commits intoRedMadRobot:masterfrom
aduuub wants to merge 3 commits intoRedMadRobot:masterfrom
Conversation
… file exported from Figma
Contributor
|
It might be worth adding API support as well? |
|
radicool! |
Contributor
|
Any plans to merge this PR? |
Collaborator
FigmaExport already supports exporting colors from variables. See #236 Do you want to import variables from JSON file? |
Contributor
Great, missed that one. thx |
09f1aeb to
154b34e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our design team uses variables (which has been described as the new way of doing things- see the screenshot). It's a way of structuring your colours to use with a variable name with a "light" and "dark" scheme.
It would be great to be able to use this tool with them instead of Figma styles and although it's new, it's the way Figma is apparently going in and to me makes more sense having a single colour e.g.
BackgroundDefaultinstead ofBackgroundDefault_lightThe API for this is still in beta and is for enterprise customers only. In the short-term, you can use a Figma plugin Variables to JSON to download the variables as JSON and specify a path to the file in the config. Each variable should have a "light" state, but can also include "dark", "lightHC", "darkHC" too.
If you want to provide the JSON yourself, the variables should be in the following format. It supports reading from hex and rgba along with traversing through the folder structures.
To use this should specify the following properties in the colors common config
useVariablesFromFileInstead: truevariableFilePath: 'path-to-styles.json'variableGroupName: 'app-tokens-or-token-group-name'