Implement "files/:file_id/versions" API#258
Open
alessioarsuffi wants to merge 10 commits intoRedMadRobot:masterfrom
Open
Implement "files/:file_id/versions" API#258alessioarsuffi wants to merge 10 commits intoRedMadRobot:masterfrom
alessioarsuffi wants to merge 10 commits intoRedMadRobot:masterfrom
Conversation
added 10 commits
May 26, 2025 12:53
Author
|
Don't know who to tag, suggestions are more than welcome, many thanks 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR introduces a new function
shouldUpdateFigmaVersionthat compares the remote Figma file version date with the locally stored date for a specific asset type (e.g., images, icons, typography, colors). If the remote version is more recent, it updates the local version and fetch the specified assets.There is a new file called
figma-versions.json. Which will have the following structure:{ "icons" : "2025-05-26T08:06:03Z", "images" : "2025-05-26T08:06:03Z", "colors" : "2025-05-26T08:06:03Z", "typography" : "2025-05-26T08:06:03Z" }This is due to the fact that we want to download one of the following asset type based on the latest figma file version.
Scenario:
figma-export colors:The script will produce the following log before fetching the colors:
If the designer releases a new file version, the subsequent commands will fetch the selected assets.
✅ Changes:
shouldUpdateFigmaVersionto detect and sync the latest Figma version per asset key.Possible enhancements:
If you have any further comment, idea, question etc I'm open for feedbacks :)
Thank you