Skip to content

Conversation

@stefanatwork
Copy link
Collaborator

Internal task scheduler is now outside of RTC namespace matching the other schedulers.

Internal task scheduler is now outside of RTC namespace
matching the other schedulers.
@stefanatwork stefanatwork added this to the v4.4.1 milestone Oct 7, 2025
@stefanatwork stefanatwork self-assigned this Oct 7, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Moves the internal TaskScheduler out of the RTC namespace to align with other schedulers and fix compilation issues arising from prior dual-namespace exposure.

  • Removed RTC_NAMESPACE_BEGIN / RTC_NAMESPACE_END wrapping and the conditional using-alias.
  • Eliminated the explanatory comment about exporting symbols via RTC namespace without replacement.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
common/tasking/taskschedulerinternal.h Removed RTC namespace wrapping, alias, and related comment; TaskScheduler now directly in embree namespace.
common/tasking/taskschedulerinternal.cpp Removed RTC namespace macro wrappers around implementation to match header change.
Comments suppressed due to low confidence (2)

common/tasking/taskschedulerinternal.h:1

  • The removal of this explanatory comment without a replacement loses rationale for prior namespace handling. If the dual-namespace exposure is intentionally deprecated, add a brief comment stating that TaskScheduler is now only in embree:: to align with other schedulers and that the RTC namespace exposure was removed.
// Copyright 2009-2021 Intel Corporation

common/tasking/taskschedulerinternal.h:1

  • Removing RTC_NAMESPACE_END and the conditional using-alias eliminates the symbol path (e.g. rtc::TaskScheduler or whatever RTC_NAMESPACE expands to). This is a potential breaking change for downstream code that referenced the namespaced version. Consider providing a backward-compatibility typedef/alias guarded by a deprecation macro until the next major release, or document the breaking change explicitly.
// Copyright 2009-2021 Intel Corporation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@stefanatwork stefanatwork merged commit a509d1e into master Oct 8, 2025
4 checks passed
@stefanatwork stefanatwork deleted the sw/internal_tasking branch October 8, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants