CU-868ex18rd Fix for ad hoc build

[ucswift]

Summary by CodeRabbit

• Chores
  • Aligned internal build naming with production by removing the “.internal” suffix from app identifiers. Internal builds will now use the base app name/ID, which may affect installation or update behavior for internal testers.
  • Updated build configuration settings to support the new behavior; no impact on public app functionality.

[coderabbitai]

Walkthrough

The changes add a new boolean property to the cli section of eas.json and adjust withEnvSuffix in env.js to treat 'internal' like 'production' by not appending an environment suffix. No exports or public interfaces are modified.

Changes

Cohort / File(s)	Summary
Build config (EAS) eas.json	Added a new boolean property Gs7z9TTJwAKyxN4G3YWPFfDmnUo3ofu8q2QSWfdxtNUt under cli set to false; adjusted JSON formatting (trailing comma on version).
Env suffix logic env.js	Updated withEnvSuffix: returns base for APP_ENV in {'production','internal'}; otherwise appends .<APP_ENV>. Impacts BUNDLE_ID/PACKAGE for internal builds by removing .internal suffix.

Sequence Diagram(s)

sequenceDiagram
  participant Caller as Build/Config Caller
  participant Env as withEnvSuffix(APP_ENV, base)
  note over Caller,Env: Determine identifier based on APP_ENV

  Caller->>Env: request(base, APP_ENV)
  alt APP_ENV is "production" or "internal"
    Env-->>Caller: base
    note right of Env: No suffix applied
  else other envs (e.g., development, staging)
    Env-->>Caller: base + "." + APP_ENV
    note right of Env: Suffix applied
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibbled configs, twitching with delight,
A secret flag tucked safely out of sight.
Env tails trimmed—no “.internal” tonight—
Bundles hop clean in the moonlit byte.
Thump-thump: builds ready, ears up, all right! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6514bd1 and 5f28999.

📒 Files selected for processing (2)

• eas.json (2 hunks)
• env.js (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: test

🔇 Additional comments (3)

eas.json (2)

102-102: LGTM — formatting-only JSON change.

No functional impact.

---

3-4: Ignore suggestion for Gs7z9TTJwAKyxN4G3YWPFfDmnUo3ofu8q2QSWfdxtNUt; Gs7z9TTJwAKyxN4G3YWPFfDmnUo3ofu8q2QSWfdxtNUt under cli is officially supported in eas.json (docs.expo.dev).

Likely an incorrect or invalid review comment.

env.js (1)

51-53: Verify side effects of treating internal like production

• Devices with the App Store build will replace (not co-install) the internal build due to identical bundle IDs.
• Ensure Apple/Google credentials exist for the base IDs to avoid EAS signing failures.
• Confirm no code or config (deep links, routing, entitlements, etc.) relies on a .internal suffix.
• Small readability nit: prefer an allowlist expression:

- return APP_ENV === 'production' || APP_ENV === 'internal' ? name : `${name}.${APP_ENV}`;
+ return ['production','internal'].includes(APP_ENV) ? name : `${name}.${APP_ENV}`;

• Update the nearby comment to note that “internal” now uses the base (unsuffixed) ID.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ucswift]

Approve

[github-actions]

This PR is approved.