Skip to content

CU-868ex18rd Fixing missing analytic key env.#73

Merged
ucswift merged 1 commit intomasterfrom
develop
Sep 9, 2025
Merged

CU-868ex18rd Fixing missing analytic key env.#73
ucswift merged 1 commit intomasterfrom
develop

Conversation

@ucswift
Copy link
Member

@ucswift ucswift commented Sep 9, 2025

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration by adding two new environment variables sourced from repository secrets.
    • Change is limited to the build pipeline; there are no modifications to app functionality, UI, or performance.
    • No user action is required; existing features continue to work as before.
    • This update helps ensure consistent build environments across deployments without altering runtime behavior.
    • No impact on previously saved data, settings, or compatibility.

@coderabbitai
Copy link

coderabbitai bot commented Sep 9, 2025

Walkthrough

The React Native CI/CD GitHub Actions workflow adds two environment variables, RESPOND_APTABASE_APP_KEY and RESPOND_APTABASE_URL, sourced from repository secrets. No steps, jobs, or control flow were changed.

Changes

Cohort / File(s) Summary of edits
CI workflow env vars
.github/workflows/react-native-cicd.yml
Added env variables RESPOND_APTABASE_APP_KEY and RESPOND_APTABASE_URL, mapped to secrets.RESPOND_APTABASE_APP_KEY and secrets.RESPOND_APTABASE_URL.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks (2 passed, 1 warning)

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request currently lacks any description summarizing the changes and therefore provides no context about the two new environment variables in the CI workflow, making it unrelated or absent relative to the changeset. Please add a concise description that summarizes the addition of RESPOND_APTABASE_APP_KEY and RESPOND_APTABASE_URL to the CI workflow and explains their purpose.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “CU-868ex18rd Fixing missing analytic key env.” directly references a real aspect of the changeset by highlighting the addition of the missing analytics environment variable and is specific enough to understand the primary fix, even though it doesn’t enumerate every detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

I twitch my nose at secrets new,
Two keys now hop into the brew.
In workflows where the runners tread,
Aptabase paths are softly spread.
A gentle change, no storms to see—
Just greener fields of CI glee. 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ucswift
Copy link
Member Author

ucswift commented Sep 9, 2025

Approve

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit e011c2f into master Sep 9, 2025
11 of 12 checks passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/react-native-cicd.yml (1)

71-72: Scope secrets to where they’re needed.

Consider moving these two vars from the top-level env to the build-and-deploy job (or the RNBuild environment) to minimize exposure to non-build jobs. Keeps blast radius smaller without changing behavior.

 env:
@@
-  RESPOND_APTABASE_APP_KEY: ${{ secrets.RESPOND_APTABASE_APP_KEY }}
-  RESPOND_APTABASE_URL: ${{ secrets.RESPOND_APTABASE_URL }}
 
 jobs:
   build-and-deploy:
     needs: test
@@
     environment: RNBuild
+    env:
+      RESPOND_APTABASE_APP_KEY: ${{ secrets.RESPOND_APTABASE_APP_KEY }}
+      RESPOND_APTABASE_URL: ${{ secrets.RESPOND_APTABASE_URL }}
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3feb5cb and 63ba73a.

📒 Files selected for processing (1)
  • .github/workflows/react-native-cicd.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
.github/workflows/react-native-cicd.yml (1)

71-72: Aptabase CI secrets match env.js and code usage; no additional Expo config mapping required.

@coderabbitai coderabbitai bot mentioned this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant