feat: migrate reorder site awards to inertia#4536
Draft
Chew wants to merge 7 commits intoRetroAchievements:masterfrom
Draft
feat: migrate reorder site awards to inertia#4536Chew wants to merge 7 commits intoRetroAchievements:masterfrom
Chew wants to merge 7 commits intoRetroAchievements:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very long and tedious process.
The primary goal of this conversion is to simply 1:1 the page for now. This requires migrating a ton of code that is only used on this page to be used to be React components.
However, a handful of functions are re-used elsewhere, making these functions have tacked on methods that make it harder to rip out and use.
Specifically, RenderAward has a ton of stuff in there to let it be used extremely dynamically, at the cost of it being hard to move around when actually needed.
Ideally, large parts of the old code is rewritten solely with this in mind. There are surely more efficient ways to get the data we need.
Steps before ready: