feat(api): add V2 JSON:API relationship endpoint for PlayerAchievementSet resources#4562
Merged
wescopeland merged 7 commits intoRetroAchievements:masterfrom Feb 23, 2026
Merged
Conversation
Jamiras
reviewed
Feb 17, 2026
app/Api/V2/PlayerAchievementSets/PlayerAchievementSetSchema.php
Outdated
Show resolved
Hide resolved
app/Api/V2/PlayerAchievementSets/PlayerAchievementSetSchema.php
Outdated
Show resolved
Hide resolved
app/Api/V2/PlayerAchievementSets/PlayerAchievementSetSchema.php
Outdated
Show resolved
Hide resolved
Jamiras
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a V2 API relationship endpoint for
PlayerAchievementSetresources. This is a follow-up to #4528.These resources are accessible by two means:
GET /users/{user}/player-achievement-sets.GET /users/{user}/player-games?include=playerAchievementSets, which allows per-set breakdowns of the retrievedPlayerGamerecords.Things worth noting:
PlayerAchievementSetresources. These records only make sense in the context of other related or parent records.-lastUnlockAt(most recent activity first), mirroringPlayerGameSchema's-lastPlayedAtpattern.achievementSetandgamerelationships can be included via?include=achievementSetor?include=game.filter[gameId]param filters to achievement sets for a specific game (it joins throughgame_achievement_sets).UserScopedHasManyThroughrelationship class was needed for the sidewaysplayer-games?include=playerAchievementSets.How to test this PR