Skip to content

Comments

chore: split vitest and vite configs#4568

Merged
wescopeland merged 2 commits intoRetroAchievements:masterfrom
wescopeland:vitest-config
Feb 19, 2026
Merged

chore: split vitest and vite configs#4568
wescopeland merged 2 commits intoRetroAchievements:masterfrom
wescopeland:vitest-config

Conversation

@wescopeland
Copy link
Member

@wescopeland wescopeland commented Feb 18, 2026

When running pnpm dev, Vite starts a dev server with hot reload enabled on a specific port. If you then run pnpm test in another terminal tab, it reads the same vite.config.ts file and spins up its own internal Vite server.

Because they share the same config, Vitest's Vite instance conflicts with the already-running dev server, and it blows your local dev server's internal assets away. I have to always restart pnpm dev after running tests.

This is fixed in this PR by splitting out Vitest's config into its own file. There are no functional changes as part of this PR, it's purely a QoL local dev improvement. I'm probably the only one who gets hit by this regularly - I only just now realized it's because of the single config file.

@wescopeland wescopeland requested a review from a team February 18, 2026 00:00
@wescopeland wescopeland enabled auto-merge (squash) February 19, 2026 16:25
@wescopeland wescopeland merged commit ad132cc into RetroAchievements:master Feb 19, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants