fix: remove avif fallback banners#4584
Open
wescopeland wants to merge 1 commit intoRetroAchievements:masterfrom
Open
fix: remove avif fallback banners#4584wescopeland wants to merge 1 commit intoRetroAchievements:masterfrom
wescopeland wants to merge 1 commit intoRetroAchievements:masterfrom
Conversation
wescopeland
commented
Feb 21, 2026
Member
Author
There was a problem hiding this comment.
I'm not a fan of shoving WebP files into fields clearly labeled as AVIF, but I couldn't think of a better idea that also didn't involve a lot of pain over something that's probably superficial.
Member
There was a problem hiding this comment.
is there some way to just get the code to prefer the webp over the avif? why are both needed?
Jamiras
approved these changes
Feb 23, 2026
Member
There was a problem hiding this comment.
is there some way to just get the code to prefer the webp over the avif? why are both needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://discord.com/channels/310192285306454017/758865736072167474/1474516509563949097.
It turns out AVIF is probably the least optimal compression algorithm for the specific image used as our banner fallback.
Uncompressed Source
WebP
AVIF
AVIF is good at compressing photos (ie: most conventional banners), but is not good at compressing this sort of fine detail spread all over a single continuous image.
This PR makes several changes:
Spatie\Image\Imageto using rawImagick. On my local, I accidentally generated fallbacks using the GD driver, which compresses significantly worse than Imagick.