-
Notifications
You must be signed in to change notification settings - Fork 30
Document ads charts #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Document ads charts #1313
Conversation
|
Preview this PR here: https://dev-docs.revenuecat.com/pr-1313/ |
polmiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice that all links in the ads charts specifications here are still commented out and should be uncommented once this is rolled out.
polmiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple minor suggestions and a follow-up for uncommenting the links in the charts spec once this is deployed.
Side topic: eventually we may want to add an "Ads monetization model" here.
| link: "dashboard-and-metrics/charts/subscriptions", | ||
| }, | ||
| }), | ||
| SubCategory({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until we do a public release we should skip adding these to the sidebar and just make them reachable via the charts links in the Dashboard that only appear when the relevant feature flags are active. You can leave a PR open and ready with the change in this file for when the time comes.
| @@ -0,0 +1,50 @@ | |||
| --- | |||
| title: Ad Impressions Chart | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
This applies to all the charts
We removed the Ad prefix prefix for all ads charts in the Dashboard since it felt redundant. This title is also used in the sidebar where the redundancy is obvious. For consistency I would suggest removing it here as well. Not a strong opinion by any means.
| ], | ||
| index: { | ||
| title: "Ads", | ||
| link: "dashboard-and-metrics/charts/ads", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this documentation page does not exist yet?
Motivation / Description / Changes introduced
This PR adds all the necessary documentation supporting the new ads charts we're introducing as part of the ads tracking feature.