Skip to content

Conversation

@patrickwarner
Copy link

Motivation / Description / Changes introduced

This PR adds all the necessary documentation supporting the new ads charts we're introducing as part of the ads tracking feature.

@patrickwarner patrickwarner requested a review from a team as a code owner January 9, 2026 18:43
@patrickwarner patrickwarner requested a review from polmiro January 9, 2026 18:44
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Preview this PR here: https://dev-docs.revenuecat.com/pr-1313/

Copy link
Member

@polmiro polmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that all links in the ads charts specifications here are still commented out and should be uncommented once this is rolled out.

Copy link
Member

@polmiro polmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple minor suggestions and a follow-up for uncommenting the links in the charts spec once this is deployed.

Side topic: eventually we may want to add an "Ads monetization model" here.

link: "dashboard-and-metrics/charts/subscriptions",
},
}),
SubCategory({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until we do a public release we should skip adding these to the sidebar and just make them reachable via the charts links in the Dashboard that only appear when the relevant feature flags are active. You can leave a PR open and ready with the change in this file for when the time comes.

@@ -0,0 +1,50 @@
---
title: Ad Impressions Chart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This applies to all the charts

We removed the Ad prefix prefix for all ads charts in the Dashboard since it felt redundant. This title is also used in the sidebar where the redundancy is obvious. For consistency I would suggest removing it here as well. Not a strong opinion by any means.

],
index: {
title: "Ads",
link: "dashboard-and-metrics/charts/ads",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this documentation page does not exist yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants