Conversation
demonstration using the modules_extra to add custom plugins to SRL
Collaborator
Author
|
there's a typo in the file copy, let me fix that.. |
ReyeMe
requested changes
Jan 31, 2026
Owner
There was a problem hiding this comment.
Not cross-compatible bat, use the same as run_with_mednafen.bat, just replace mednafen with kronos
Owner
There was a problem hiding this comment.
Not cross-compatible bat, use the same as run_with_mednafen.bat, just replace mednafen with ymir.
see folder ./tools/scripts/run.bat and ./tools/scripts/run.sh, and add ymir support there
saturnringlib/shared.mk
Outdated
Owner
There was a problem hiding this comment.
pointless for, only once coue per project exists
Owner
There was a problem hiding this comment.
remove unrelated comment on this line and also on line 14
will deal with the addition of ymir batch scripts in a separate PR
ended up being simple enough so I just included it here
or at least, attempt to...
ReyeMe
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstrate use of MODULES_EXTRA
note: there was some discussion on changing include module.mk to make module.mk in shared.mk. I don't fully understand what needs to change for that to work - I'm open to suggestions, but this does work as-is.