Using R_xlen_t instead of int so that larger matrices can be computed…#32
Open
jaredlander wants to merge 1 commit intoRfastOfficial:masterfrom
Open
Using R_xlen_t instead of int so that larger matrices can be computed…#32jaredlander wants to merge 1 commit intoRfastOfficial:masterfrom
jaredlander wants to merge 1 commit intoRfastOfficial:masterfrom
Conversation
… on using vector mode. The standard int has a size limit of 2^31 which can be exceeded when computing distance on a matrix with more than 46,342 rows. I didn't change the matrix return formats because that shouldn't be as much of a problem since you can have a 32-bit integer in either direction.
Author
|
Just saw your reply. Sorry for the delay. It's not about the loop exceeding the int size, it's about the total size. Particularly |
Contributor
|
You mean for example 50000*50000 which is bigger than 2^31. Yes ok but I will change with size_t and let C++ do its magic. When I change it you better merge the new version to your master or change it by yourself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… on using vector mode. The standard int has a size limit of 2^31 which can be exceeded when computing distance on a matrix with more than 46,342 rows.
I didn't change the matrix return formats because that shouldn't be as much of a problem since you can have a 32-bit integer in either direction.