Add input length validation for agent fields#30
Open
mduongvandinh wants to merge 1 commit intoRightNow-AI:mainfrom
Open
Add input length validation for agent fields#30mduongvandinh wants to merge 1 commit intoRightNow-AI:mainfrom
mduongvandinh wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
Add MAX_AGENT_NAME_LEN (256), MAX_AGENT_DESCRIPTION_LEN (4096), and MAX_SYSTEM_PROMPT_LEN (64KB) guards to patch_agent_config and clone_agent endpoints. Prevents unbounded string storage in SQLite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
MAX_AGENT_NAME_LEN(256 chars) fornameinpatch_agent_configandnew_nameinclone_agentMAX_AGENT_DESCRIPTION_LEN(4096 chars) fordescriptioninpatch_agent_configMAX_SYSTEM_PROMPT_LEN(64KB) forsystem_promptinpatch_agent_config413 Payload Too Largewith descriptive error messageTest plan
cargo build -p openfang-api --libpassescargo clippy -p openfang-api --all-targets -- -D warningszero warningscargo fmt --all --checkcleanMAX_MESSAGE_SIZEvalidation patternFiles changed
crates/openfang-api/src/routes.rs(+43)