fix(installer): robust shell detection and fish-safe PATH update#75
Open
Dwsy wants to merge 1 commit intoRightNow-AI:mainfrom
Open
fix(installer): robust shell detection and fish-safe PATH update#75Dwsy wants to merge 1 commit intoRightNow-AI:mainfrom
Dwsy wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPENFANG_SHELL->$SHELL-> parent process -> grandparent processfish_add_pathinstead of POSIXexport PATH=...syntaxexport PATH=...)~/.profile)Why
When users run
curl -fsSL https://openfang.sh/install | shfrom fish, shell detection can be ambiguous and PATH lines must be fish-native. Using POSIX export syntax in fish can break PATH and hide core commands.Validation
bash -n scripts/install.shfish -c,SHELL=/bin/sh)fish~/.config/fish/config.fishOPENFANG_SHELL=fish|zsh)fish_add_path "<install_dir>"to fish configexport PATH="<install_dir>:$PATH"to bash profileScope
No platform download/extract logic changed. Linux/macOS target resolution remains untouched.