Fix GGUF tensor alignment and validate model config#20
Open
dipeshbabu wants to merge 2 commits intoRightNow-AI:mainfrom
Open
Fix GGUF tensor alignment and validate model config#20dipeshbabu wants to merge 2 commits intoRightNow-AI:mainfrom
dipeshbabu wants to merge 2 commits intoRightNow-AI:mainfrom
Conversation
Author
|
This also fixes for avoiding per-token malloc/leak by using mmap string views. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash-prone bug in GGUF parsing where tensor data base offset was computed using a bitmask that only works when
general.alignmentis a non-zero power of two. If alignment is missing/malformed (or non power-of-two), the model can read incorrect mmap offsets and crash.Changes:
align_up_any()implementation for tensor data base alignment.n_kv_headston_headswhen omitted.n_embd % n_heads == 0before computing head_dim.Tests:
make clean && make native(Linux x86_64)