Add patch for imu_tools package#330
Add patch for imu_tools package#330traversaro merged 1 commit intoRoboStack:mainfrom wentywenty:main
Conversation
|
Run ls output/emscripten-wasm32 This error in the sixth item of GitHub cil, do I need to modify any other files? |
|
0s env: |
|
This should not be my PR issue. |
|
Yes, that is a bug in the PR logic, feel free to ignore, thanks! Anyhow, yo ensure that the package is actually built, you need to increase its build number in https://github.com/RoboStack/ros-humble/blob/main/pkg_additional_info.yaml, and raise the build number in the comment in Line 8 in 3cd1c60 |
Okay. |
|
Do I need to modify the build number in pkg_additional_info.yaml and the comments in vinca.yaml according to your instructions?
|
|
Ah, my bad, I was confused by the title of the PR, if the package was not built before there is no need to bump the build number. |
Thank you! |
|
@wentywenty Thanks you for the PR! In case you are interested in this, it may be useful to also propose the change you added here in https://github.com/CCNYRoboticsLab/imu_tools, so that we reduce the amount of patches we maintain locally here, see RoboStack/robostack.github.io#16 for issue on this effort in general. |
okay~I have submitted a merge request. |
|
Thanks! |
Fixes Windows-specific compilation issues