Fix BRDF initialization in rhi-null use case#12
Merged
jhanca-robotecai merged 1 commit intojh/simulation-cherriesfrom Feb 5, 2025
Merged
Fix BRDF initialization in rhi-null use case#12jhanca-robotecai merged 1 commit intojh/simulation-cherriesfrom
jhanca-robotecai merged 1 commit intojh/simulation-cherriesfrom
Conversation
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
jhanca-robotecai
approved these changes
Feb 5, 2025
mateuszwasilewski
pushed a commit
that referenced
this pull request
Apr 15, 2025
* Fix use case for Star Gem in console mode (o3de#18475) * Fix use case for Star Gem in console mode Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> * Fix sky atmosphere for multiple pipelines (o3de#18476) Signed-off-by: Artur Kamieniecki <artur.kamieniecki@robotec.ai> * partial cherry-pick: Quest specular fix (o3de#18510) Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * Added logic to boostrap component that run BRDF pipeline in console mode (o3de#18531) Co-authored-by: Jan Hanca <jan.hanca@robotec.ai> Co-authored-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> * Add function "Allow pipeline changes" to CameraComponent (o3de#18524) * Add function "Allow pipeline changes" to CameraComponent This is usefull for rendering to texture using features like: - Sky atmosphere - Global illumination Since a lot of feaures processors don't beheave with multiple cameras this function is activated after changing registry setting: `/O3DE/Atom/ExperimentalFeaturesEnabled` to `true` It is to prevent exposure of this function to the majority of users. This function allows to change the camera pipeline in runtime --------- Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> * Fix BRDF initialization in rhi-null use case (#12) Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> --------- Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Artur Kamieniecki <artur.kamieniecki@robotec.ai> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Co-authored-by: Michał Pełka <michal.pelka@robotec.ai> Co-authored-by: Artur Kamieniecki <artur.kamieniecki@robotec.ai> Co-authored-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes null pointer dereferencing that can be caused by running
-rhi=nullscenario.It was experienced here : o3de#18649 (comment).
This PR does not require fix in development, since code in
BootstrapSystemComponent.cppis heavily modified in dev comparing to 2409.1How was this PR tested?
Run game launcher with and test against issue o3de/o3de-extras#792.
-rhi=null -console-mode- starts without assertions and crashes (produce some warnings regarding ROS 2 Gem)-rhi=vulkan -console-mode- works, does not reintroduce issue