Turning ROS2-For-Unity into a package#95
Open
Deric-W wants to merge 6 commits intoRobotecAI:developfrom
Open
Conversation
This allows better reuse, samples and tests. Furthermore, the packaging of `ros2-for-unity.xml` is now being done by Unity as well as setting up the path and doing integrity checks.
The old examples where moved into the new ones.
It seems that this is closer to the recommended layout
|
Looks neat @Deric-W ! Until this gets merged I'll be basing my own forked works on this. EDIT: Maybe, as the diff is pretty huge, you could complete the list in your first message with all the changes made? I imagine bullets like 'moved Scripts to Runtime' and 'replaced path variables by Resources helper', etc. |
|
@Deric-W I've started using your branch in my own project EDIT: Oops, fault was mine. Can confirm custom message still work fine as a package! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this pull request has the same goal as #94 but with the following extra features:
ros2-for-unity.xmlis now being packaged by UnityROS2ForUnitywhere moved to a separateSetupclass and marked private or internal where possibleRuntimeInitializeOnLoadMethodmarked methods in edit mode the user has to call the method to setup the path manually in this case (for example usingOneTimeSetUpin NUnit tests)If these features are wanted then this PR could replace #94.