Open
Conversation
It is not mentioned in the README.
This commit only builds packages contained in `src/ros2cs` and `src/custom_packages` and their dependencies to speed up the build process. Furthermore, it makes building the examples optional.
The workflow will run the tests with the supported ros distributions on all supported platforms. To prevent unnecessary runs its is only triggered by pushes or pull requests to master or manually.
Contributor
Author
|
The jobs take 9 (Ubuntu) and 40 (Windows) minutes, if you want I can look into setting up caching for the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #48 by setting up two Github Actions workflows (for Ubuntu and Windows).
Furthermore, it removes foxy declarations which are not supported anymore and reduces the amount of packages being build by only building ros2cs and custom packages in
src/custom_packagesand their dependencies.While there are existing actions for ROS CI like ros-tooling/setup-ros and ros-tooling/action-ros-ci their use caused errors or unecessary slowdowns when selecting the Python version, see ros-tooling/setup-ros#552 and ros-tooling/setup-ros#439.
Currently the only ROS version being tested is humble, if you want I can add jobs for other versions.
To not waste CI minutes the jobs only run on commits or Pull Requests to master (which I assume is the "stable" branch) but can be triggered manually.